Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbbLDGXr (ORCPT ); Fri, 4 Dec 2015 01:23:47 -0500 Received: from mga02.intel.com ([134.134.136.20]:13148 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbbLDGXp convert rfc822-to-8bit (ORCPT ); Fri, 4 Dec 2015 01:23:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,380,1444719600"; d="scan'208";a="866418098" From: "Dilger, Andreas" To: Valdis Kletnieks , "Drokin, Oleg" CC: "lustre-devel@lists.lustre.org" , "linux-kernel@vger.kernel.org" Subject: Re: [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Thread-Topic: [lustre cleanups 0/6] Patch series to make lustre safe(r) for W=1 compiles Thread-Index: AQHRLISKZFCFosh8L0Oo+aQr2GXXJ566cF+A Date: Fri, 4 Dec 2015 06:23:43 +0000 Message-ID: References: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> In-Reply-To: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.133.71] Content-Type: text/plain; charset="us-ascii" Content-ID: <59C88DCE78719B448591DC5CD2AFC93F@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 58 On 2015/12/01, 15:05, "Valdis Kletnieks" wrote: >Start of a batch series to clean up the Lustre tree. Other people have >done some sparse and checkpatch cleanups, but I found a bunch of >stuff building with W=1. Hello Valdis, thanks for these patches. Strictly speaking, they should also be sent to "Greg Kroah-Hartman " and also devel@driverdev.osuosl.org because Lustre is still in the staging tree. Also, for the patch subject line, it is standard to use something like: [PATCH 1/6] staging/lustre: Swap inline/const to kill 272 warnings as generated by "git format-patch". Could you please resubmit your patch series so that Greg sees your patches. Cheers, Andreas >Valdis Kletnieks (6): > > Swap inline/const to kill 272 warnings > Fix set-but-unused whinge. > Clean up another C warnining: > Fix another C compiler whine: > Nuke an unsigned >= 0 assert > Nuke another unsigned >= 0 assert > > drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 + > drivers/staging/lustre/lustre/include/lu_object.h | 2 +- > drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 -- > drivers/staging/lustre/lustre/libcfs/module.c | 15 ++++---- > drivers/staging/lustre/lustre/llite/rw.c | 1 - > drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 - > 7 files changed, 26 insertions(+), 41 deletions(-) > >-- >2.6.3 > > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/