Date: Fri, 4 Dec 2015 08:34:37 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Xunlei Pang <xlpang@redhat.com>
Subject: Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr
 is zero
Message-ID: <20151204073437.GA24827@gmail.com>
References: <20151203172428.600f380a@gandalf.local.home>
 <87lh9b573j.fsf@rustcorp.com.au>
 <20151203213745.52f21886@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151203213745.52f21886@gandalf.local.home>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1088
Lines: 29


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Fri, 04 Dec 2015 12:05:12 +1030
> Rusty Russell <rusty@rustcorp.com.au> wrote:
> 
> > This is clever, but I would advise against such subtle code.  We will never be 
> > able to remove this code once it is in.
> > 
> > Would suggest making the non-CPUMASK_OFFSTACK stubs write garbage into the 
> > cpumasks instead, iff !(flags & __GFP_ZERO).
>
> I actually thought of the same thing, but thought it was a bit harsh. If others 
> think that's a better solution, then I'll submit a patch to do that.

That just makes things more fragile - 'garbage' will spread the breakage, and if 
the breakage is subtle, it will spread subtle breakage.

So why not use a kzmalloc_node() [equivalent] call instead of kmalloc_node(), to 
make sure it's all zeroed instead of uninitialized?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/