Date: Fri, 4 Dec 2015 09:11:27 +0100
From: Pavel Machek <pavel@ucw.cz>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, mhocko@kernel.org, akpm@osdl.org,
        linux-kernel@vger.kernel.org, jcliburn@gmail.com,
        chris.snook@gmail.com, netdev@vger.kernel.org, rjw@rjwysocki.net,
        linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com,
        ebiederm@xmission.com
Subject: Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC
 allocation
Message-ID: <20151204081127.GA29367@amd>
References: <20151128145113.GB4135@amd>
 <20151203155905.GA31974@amd>
 <1449163048.25029.2.camel@edumazet-glaptop2.roam.corp.google.com>
 <20151203.123249.2158644928982094593.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151203.123249.2158644928982094593.davem@davemloft.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 970
Lines: 28

> >>  	if (unlikely(!ring_header->desc)) {
> >> -		dev_err(&pdev->dev, "pci_alloc_consistend failed\n");
> >> +		dev_err(&pdev->dev, "could not get memory for DMA buffer\n");
> >>  		goto err_nomem;
> >>  	}
> >>  	memset(ring_header->desc, 0, ring_header->size);
> >> 
> >> 
> > 
> > So this memset() will really require a different patch to get removed ?
> > 
> > Sigh, not sure why I review patches.
> 
> Agreed, please use dma_zalloc_coherent() and kill that memset().

Ok, updated. I'll also add cc: stable, because it makes notebooks with
affected chipset unusable.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/