Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755430AbbLDIac (ORCPT ); Fri, 4 Dec 2015 03:30:32 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35742 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755275AbbLDIab (ORCPT ); Fri, 4 Dec 2015 03:30:31 -0500 Date: Fri, 4 Dec 2015 09:30:26 +0100 From: Ingo Molnar To: Peter Zijlstra Cc: Xunlei Pang , linux-kernel@vger.kernel.org, Ingo Molnar , Steven Rostedt , Rusty Russell Subject: Re: [PATCH] sched/core: Clear the root_domain cpumasks in init_rootdomain() Message-ID: <20151204083026.GA32345@gmail.com> References: <1449057179-29321-1-git-send-email-xlpang@redhat.com> <20151202123414.GB9928@worktop.ger.corp.intel.com> <565EEE3E.30301@redhat.com> <20151202162542.GT3816@twins.programming.kicks-ass.net> <565FAC78.3030205@redhat.com> <20151203082800.GA2321@gmail.com> <56602D19.5080308@redhat.com> <20151204080901.GA26934@gmail.com> <20151204082703.GD17308@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151204082703.GD17308@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 24 * Peter Zijlstra wrote: > On Fri, Dec 04, 2015 at 09:09:01AM +0100, Ingo Molnar wrote: > > and then this code: > > > > > > cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map); > > > > uses it without first clearing it. > > > > So is this another such bug, or am I missing something? > > It uses it as destination, it does a complete write of the mask. ah, indeed! The cpumask primitive confused me. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/