Subject: Re: [PATCH v2] drm/radeon: Retry DDC probing on DVI on failure if we
 got an HPD interrupt
To: Boszormenyi Zoltan <zboszor@pr.hu>, <cpaul@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>, <dri-devel@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>
References: <BLUPR12MB06912378867E0AA0D3AC06EFF7070@BLUPR12MB0691.namprd12.prod.outlook.com>
 <1449185167-6886-1-git-send-email-cpaul@redhat.com>
 <566154A0.5050205@amd.com> <56616029.1010007@pr.hu>
CC: Jerome Glisse <jglisse@redhat.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <566162DA.40107@amd.com>
Date: Fri, 4 Dec 2015 10:54:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <56616029.1010007@pr.hu>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2015 09:54:46.7214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0130
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1931
Lines: 46

On 04.12.2015 10:43, Boszormenyi Zoltan wrote:
> 2015-12-04 09:53 keltezéssel, Christian König írta:
>> On 04.12.2015 00:26, cpaul@redhat.com wrote:
>>> From: Lyude <cpaul@redhat.com>
>>>
>>> HPD signals on DVI ports can be fired off before the pins required for
>>> DDC probing actually make contact, due to the pins for HPD making
>>> contact first. This results in a HPD signal being asserted but DDC
>>> probing failing, resulting in hotplugging occasionally failing.
>>>
>>> This is somewhat rare on most cards (depending on what angle you plug
>>> the DVI connector in), but on some cards it happens constantly. The
>>> Radeon R5 on the machine used for testing this patch for instance, runs
>>> into this issue just about every time I try to hotplug a DVI monitor and
>>> as a result hotplugging almost never works.
>>>
>>> Rescheduling the hotplug work for a second when we run into an HPD
>>> signal with a failing DDC probe usually gives enough time for the rest
>>> of the connector's pins to make contact, and fixes this issue.
>>>
>>> Signed-off-by: Lyude <cpaul@redhat.com>
>> I find a second a bit long, but if it works so what?
>>
>> Looks sane enough to me, patch is Reviewed-by: Christian König <christian.koenig@amd.com>
> Does this patch help in case of the Radeon chip only has HDMI and DP outputs
> exposed (Zotac ZBOXNANO-AQ01) but used with DVI or VGA monitors with
> converter cables? We have some problems with such scenarios that sounds
> eerily similar to this description.

No, at least active converter cables are a completely different case.

Regards,
Christian.

>
> Inquiry-by: Zoltán Böszörményi <zboszor@pr.hu>
> ;-)
>
> Thanks in advance.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/