Date: Fri, 4 Dec 2015 11:11:44 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: Wanpeng Li <kernellwp@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Luca Abeni <luca.abeni@unitn.it>, linux-kernel@vger.kernel.org,
        Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic
Message-ID: <20151204101144.GG17308@twins.programming.kicks-ass.net>
References: <1449135730-27202-1-git-send-email-wanpeng.li@hotmail.com>
 <20151204095952.GB17354@e106622-lin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151204095952.GB17354@e106622-lin>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1052
Lines: 26

On Fri, Dec 04, 2015 at 09:59:52AM +0000, Juri Lelli wrote:
> > +		if (next_node)
> > +			dl_rq->earliest_dl.next = rb_entry(next_node,
> > +				struct task_struct, pushable_dl_tasks)->dl.deadline;
> 
> Small nitpick, we are breaking 80 columns here, checkpatch should have
> complained. I guess a different indentation could help.
> 
> Apart from this, I couldn't spot any more problems with this patch.

So I don't mind the occasional violation of that rule if it aids in
better readable code.

However, that should now have included {} because the statement is
multi-line. Coding style suggests we have braces for anything over 1
line. I'll make that edit when applying, no need to resend yet another
time :-)

> Acked-by: Juri Lelli <juri.lelli@arm.com>

Thanks, I'll try and get it queued later today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/