Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756133AbbLDKUz (ORCPT ); Fri, 4 Dec 2015 05:20:55 -0500 Received: from foss.arm.com ([217.140.101.70]:53201 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756054AbbLDKUu (ORCPT ); Fri, 4 Dec 2015 05:20:50 -0500 Date: Fri, 4 Dec 2015 10:20:48 +0000 From: Liviu Dudau To: Russell King - ARM Linux Cc: David Airlie , Catalin Marinas , Will Deacon , Rob Herring , Sudeep Holla , Jon Medhurst , Mark Rutland , Ian Campbell , Kumar Gala , Rob Herring , Pawel Moll , Arnd Bergmann , Olof Johansson , Punit Agrawal , DRI devel , devicetree , Greg Kroah-Hartman , Andrew Morton , LAKML , LKML Subject: Re: [PATCH v4 0/4] drm: Add support for the ARM HDLCD display controller Message-ID: <20151204102048.GH972@e106497-lin.cambridge.arm.com> References: <1449139249-9171-1-git-send-email-Liviu.Dudau@arm.com> <20151203165606.GS8644@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151203165606.GS8644@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2539 Lines: 71 On Thu, Dec 03, 2015 at 04:56:07PM +0000, Russell King - ARM Linux wrote: > On Thu, Dec 03, 2015 at 10:40:45AM +0000, Liviu Dudau wrote: > > This series depends on Sudeep Holla's SCPI driver (now in mainline) and on > > the tda998x patches that have been queued on Russell's patch system here [1]. > > Now merged into my tree. Thanks! Are you planning to send those for 4.5 or are they going to be patches for 4.4? > > Can I ask a fairly obvious question... > > > drivers/gpu/drm/Kconfig | 2 + > > drivers/gpu/drm/Makefile | 1 + > > drivers/gpu/drm/arm/Kconfig | 29 ++ > > drivers/gpu/drm/arm/Makefile | 2 + > > drivers/gpu/drm/arm/hdlcd_crtc.c | 327 ++++++++++++ > > drivers/gpu/drm/arm/hdlcd_drv.c | 555 +++++++++++++++++++++ > > drivers/gpu/drm/arm/hdlcd_drv.h | 42 ++ > > drivers/gpu/drm/arm/hdlcd_regs.h | 87 ++++ > > Why is the subdirectory called "arm" and not "hdlcd" ? Because I plan to add the Mali DP driver to the same directory. The HDLCD files are prefixed with the hdlcd_ string, so it should be fairly simple to distinguish the relevant files. > > ARM Ltd have more than one display controller (they have the AMBA PL110 > and PL111 in addition to this), and (afaics) this doesn't drive these. > HDLCD probably won't be the last display hardware which ARM Ltd comes > out with either. There was a PL111 DRM driver submitted at some moment, it doesn't look like it has been merged, but the plan was to have it inside the arm directory as well. I am following the amd/amdgpu|radeon idea of having a vendor directory in display/gpu/drm and then subdirectories (if it makes sense) or appropriately named files in there. > > So, I think naming the subdirectory after the vendor is probably a > mistake. It might turn out that way, but at the moment I'm not seeing too many downsides. Best regards, Liviu > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/