Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755302AbbLDKhg (ORCPT ); Fri, 4 Dec 2015 05:37:36 -0500 Received: from mail-vk0-f47.google.com ([209.85.213.47]:34536 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbbLDKhf (ORCPT ); Fri, 4 Dec 2015 05:37:35 -0500 MIME-Version: 1.0 In-Reply-To: <20151204092130.GA6979@ubuntu> References: <20151204092130.GA6979@ubuntu> Date: Fri, 4 Dec 2015 07:37:34 -0300 Message-ID: Subject: Re: [PATCH] Staging: cdrom: fix space required after that ',' From: "Geyslan G. Bem" To: "Shah, Yash (Y.)" Cc: "axboe@kernel.dk" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3561 Lines: 86 Hi Yash, 2015-12-04 6:21 GMT-03:00 Shah, Yash (Y.) : > From: Yash Shah > > fix space required after that ',' as detected by checkpatch.pl > > Signed-off-by: Yash Shah > --- > drivers/cdrom/cdrom.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index c206ccd..2d759b6 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -536,7 +536,7 @@ static int cdrom_mrw_exit(struct cdrom_device_info *cdi) > int ret; > > ret = cdrom_get_disc_info(cdi, &di); > - if (ret < 0 || ret < (int)offsetof(typeof(di),disc_type)) > + if (ret < 0 || ret < (int)offsetof(typeof(di), disc_type)) > return 1; > > ret = 0; > @@ -788,7 +788,7 @@ static int cdrom_mrw_open_write(struct cdrom_device_info *cdi) > } > > ret = cdrom_get_disc_info(cdi, &di); > - if (ret < 0 || ret < offsetof(typeof(di),disc_type)) > + if (ret < 0 || ret < offsetof(typeof(di), disc_type)) > return 1; > > if (!di.erasable) > @@ -1050,7 +1050,7 @@ int open_for_data(struct cdrom_device_info *cdi) > if (CDROM_CAN(CDC_CLOSE_TRAY) && > cdi->options & CDO_AUTO_CLOSE) { > cd_dbg(CD_OPEN, "trying to close the tray\n"); > - ret=cdo->tray_move(cdi,0); > + ret=cdo->tray_move(cdi, 0); What do you think to add spaces between equal assignment too? > if (ret) { > cd_dbg(CD_OPEN, "bummer. tried to close the tray but failed.\n"); > /* Ignore the error from the low > @@ -1215,7 +1215,7 @@ static int check_for_audio_disc(struct cdrom_device_info * cdi, > if (CDROM_CAN(CDC_CLOSE_TRAY) && > cdi->options & CDO_AUTO_CLOSE) { > cd_dbg(CD_OPEN, "trying to close the tray\n"); > - ret=cdo->tray_move(cdi,0); > + ret=cdo->tray_move(cdi, 0); > if (ret) { > cd_dbg(CD_OPEN, "bummer. tried to close tray but failed.\n"); > /* Ignore the error from the low > @@ -1591,8 +1591,8 @@ void init_cdrom_command(struct packet_command *cgc, void *buf, int len, > > /* DVD handling */ > > -#define copy_key(dest,src) memcpy((dest), (src), sizeof(dvd_key)) > -#define copy_chal(dest,src) memcpy((dest), (src), sizeof(dvd_challenge)) > +#define copy_key(dest, src) memcpy((dest), (src), sizeof(dvd_key)) > +#define copy_chal(dest, :src) memcpy((dest), (src), sizeof(dvd_challenge)) > > static void setup_report_key(struct packet_command *cgc, unsigned agid, unsigned type) > { > -- > 1.9.1 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/