Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbbLDLxU (ORCPT ); Fri, 4 Dec 2015 06:53:20 -0500 Received: from terminus.zytor.com ([198.137.202.10]:60023 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502AbbLDLxQ (ORCPT ); Fri, 4 Dec 2015 06:53:16 -0500 Date: Fri, 4 Dec 2015 03:52:32 -0800 From: tip-bot for Sasha Levin Message-ID: Cc: torvalds@linux-foundation.org, hpa@zytor.com, sasha.levin@oracle.com, linux-kernel@vger.kernel.org, peterz@infradead.org, efault@gmx.de, mingo@kernel.org, tglx@linutronix.de Reply-To: tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, efault@gmx.de, hpa@zytor.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, sasha.levin@oracle.com In-Reply-To: <1448933660-23082-1-git-send-email-sasha.levin@oracle.com> References: <1448933660-23082-1-git-send-email-sasha.levin@oracle.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] sched/core: Remove false-positive warning from wake_up_process() Git-Commit-ID: 119d6f6a3be8b424b200dcee56e74484d5445f7e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 44 Commit-ID: 119d6f6a3be8b424b200dcee56e74484d5445f7e Gitweb: http://git.kernel.org/tip/119d6f6a3be8b424b200dcee56e74484d5445f7e Author: Sasha Levin AuthorDate: Mon, 30 Nov 2015 20:34:20 -0500 Committer: Ingo Molnar CommitDate: Fri, 4 Dec 2015 10:10:16 +0100 sched/core: Remove false-positive warning from wake_up_process() Because wakeups can (fundamentally) be late, a task might not be in the expected state. Therefore testing against a task's state is racy, and can yield false positives. Signed-off-by: Sasha Levin Signed-off-by: Peter Zijlstra (Intel) Acked-by: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: oleg@redhat.com Fixes: 9067ac85d533 ("wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task") Link: http://lkml.kernel.org/r/1448933660-23082-1-git-send-email-sasha.levin@oracle.com Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 4d568ac..fc8c987 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -2039,7 +2039,6 @@ out: */ int wake_up_process(struct task_struct *p) { - WARN_ON(task_is_stopped_or_traced(p)); return try_to_wake_up(p, TASK_NORMAL, 0); } EXPORT_SYMBOL(wake_up_process); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/