Subject: Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory
 regions above MAX_DMA32_PFN
To: Igor Mammedov <imammedo@redhat.com>, Ingo Molnar <mingo@kernel.org>
References: <1449228349-243508-1-git-send-email-imammedo@redhat.com>
 <1449228349-243508-3-git-send-email-imammedo@redhat.com>
 <20151204114949.GA15308@gmail.com>
 <20151204133310.04938fb5@nial.brq.redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, konrad.wilk@oracle.com, akataria@vmware.com,
        fujita.tomonori@lab.ntt.co.jp, revers@redhat.com, riel@redhat.com
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <566188F0.4010100@redhat.com>
Date: Fri, 4 Dec 2015 13:37:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151204133310.04938fb5@nial.brq.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 742
Lines: 21


On 04/12/2015 13:33, Igor Mammedov wrote:
> That doesn't pass strict type check:
> 
> include/linux/kernel.h:730:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>   (void) (&_max1 == &_max2);  \
>                  ^
> arch/x86/mm/srat.c:206:21: note: in expansion of macro ‘max’
>   max_possible_pfn = max(max_possible_pfn, PFN_UP(end - 1));
> 
> I can change max_possible_pfn to u64 to match PFN_UP(end - 1) type.

Sounds like a good idea anyway.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/