Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752967AbbLDMug (ORCPT ); Fri, 4 Dec 2015 07:50:36 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:33596 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbbLDMue (ORCPT ); Fri, 4 Dec 2015 07:50:34 -0500 Subject: Re: [PATCH] lightnvm: place unlock sentence in the common path To: Wenwei Tao References: <1449232672-3464-1-git-send-email-ww.tao0320@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56618C17.7030705@lightnvm.io> Date: Fri, 4 Dec 2015 13:50:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449232672-3464-1-git-send-email-ww.tao0320@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1553 Lines: 47 On 12/04/2015 01:37 PM, Wenwei Tao wrote: > move spin_unlock(&vlun->lock) to common path to make > the code more clean. > > Signed-off-by: Wenwei Tao > --- > drivers/lightnvm/gennvm.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c > index 35dde84..ce60254 100644 > --- a/drivers/lightnvm/gennvm.c > +++ b/drivers/lightnvm/gennvm.c > @@ -262,14 +262,11 @@ static struct nvm_block *gennvm_get_blk(struct nvm_dev *dev, > if (list_empty(&lun->free_list)) { > pr_err_ratelimited("gennvm: lun %u have no free pages available", > lun->vlun.id); > - spin_unlock(&vlun->lock); > goto out; > } > > - while (!is_gc && lun->vlun.nr_free_blocks < lun->reserved_blocks) { > - spin_unlock(&vlun->lock); > + if (!is_gc && lun->vlun.nr_free_blocks < lun->reserved_blocks) > goto out; > - } > > blk = list_first_entry(&lun->free_list, struct nvm_block, list); > list_move_tail(&blk->list, &lun->used_list); > @@ -278,8 +275,8 @@ static struct nvm_block *gennvm_get_blk(struct nvm_dev *dev, > lun->vlun.nr_free_blocks--; > lun->vlun.nr_inuse_blocks++; > > - spin_unlock(&vlun->lock); > out: > + spin_unlock(&vlun->lock); > return blk; > } > > Thanks Tao, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/