Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbbLDORI (ORCPT ); Fri, 4 Dec 2015 09:17:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:46766 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbbLDORG (ORCPT ); Fri, 4 Dec 2015 09:17:06 -0500 Date: Fri, 4 Dec 2015 15:17:04 +0100 From: Petr Mladek To: Josh Poimboeuf Cc: Seth Jennings , Jiri Kosina , Vojtech Pavlik , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Rusty Russell , Miroslav Benes Subject: Re: [PATCH v4] livepatch: Cleanup module page permission changes Message-ID: <20151204141704.GI14230@pathway.suse.cz> References: <9b321c4c2edeaff43f21040a883891a691fc1978.1449181535.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b321c4c2edeaff43f21040a883891a691fc1978.1449181535.git.jpoimboe@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 22 On Thu 2015-12-03 16:33:26, Josh Poimboeuf wrote: > Calling set_memory_rw() and set_memory_ro() for every iteration of the > loop in klp_write_object_relocations() is messy, inefficient, and > error-prone. > > Change all the read-only pages to read-write before the loop and convert > them back to read-only again afterwards. > > Suggested-by: Miroslav Benes > Signed-off-by: Josh Poimboeuf This patch looks fine to me. Reviewed-by: Petr Mladek Thanks, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/