Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbbLDO3j (ORCPT ); Fri, 4 Dec 2015 09:29:39 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:33903 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbbLDO3i (ORCPT ); Fri, 4 Dec 2015 09:29:38 -0500 MIME-Version: 1.0 In-Reply-To: <1449002158-19156-3-git-send-email-eric@anholt.net> References: <1449002158-19156-1-git-send-email-eric@anholt.net> <1449002158-19156-3-git-send-email-eric@anholt.net> Date: Fri, 4 Dec 2015 14:29:34 +0000 Message-ID: Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. From: Emil Velikov To: Eric Anholt Cc: ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 32 Hi Eric, A couple of suggestions/requests on the UAPI header side On 1 December 2015 at 20:35, Eric Anholt wrote: > --- /dev/null > +++ b/include/uapi/drm/vc4_drm.h > +#include > + Can we make this a "drm.h" ? > +struct drm_vc4_create_bo { > + uint32_t size; > + uint32_t flags; > + /** Returned GEM handle for the BO. */ > + uint32_t handle; > + uint32_t pad; ... and not use the stdint.h types but __{s,u}* through the file. I'd rather than not nag why we want/need those, but if you prefer I can repeat myself/others. Thanks Emil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/