Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbbLDOeX (ORCPT ); Fri, 4 Dec 2015 09:34:23 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33802 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbbLDOeV (ORCPT ); Fri, 4 Dec 2015 09:34:21 -0500 Date: Fri, 4 Dec 2015 15:34:14 +0100 From: Ingo Molnar To: Paolo Bonzini Cc: Igor Mammedov , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, konrad.wilk@oracle.com, akataria@vmware.com, fujita.tomonori@lab.ntt.co.jp, revers@redhat.com, riel@redhat.com Subject: Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN Message-ID: <20151204143414.GA18020@gmail.com> References: <1449228349-243508-1-git-send-email-imammedo@redhat.com> <1449228349-243508-3-git-send-email-imammedo@redhat.com> <20151204114949.GA15308@gmail.com> <20151204133310.04938fb5@nial.brq.redhat.com> <566188F0.4010100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <566188F0.4010100@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 26 * Paolo Bonzini wrote: > On 04/12/2015 13:33, Igor Mammedov wrote: > > That doesn't pass strict type check: > > > > include/linux/kernel.h:730:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] > > (void) (&_max1 == &_max2); \ > > ^ > > arch/x86/mm/srat.c:206:21: note: in expansion of macro ‘max’ > > max_possible_pfn = max(max_possible_pfn, PFN_UP(end - 1)); > > > > I can change max_possible_pfn to u64 to match PFN_UP(end - 1) type. > > Sounds like a good idea anyway. Yeah, agreed. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/