Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbbLDO4O (ORCPT ); Fri, 4 Dec 2015 09:56:14 -0500 Received: from mail-yk0-f182.google.com ([209.85.160.182]:33875 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbbLDO4N (ORCPT ); Fri, 4 Dec 2015 09:56:13 -0500 MIME-Version: 1.0 In-Reply-To: <1448475984-11332-1-git-send-email-saurabh.truth@gmail.com> References: <1448475984-11332-1-git-send-email-saurabh.truth@gmail.com> Date: Fri, 4 Dec 2015 15:56:12 +0100 Message-ID: Subject: Re: [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags From: Ulf Hansson To: Saurabh Sengar Cc: linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 40 On 25 November 2015 at 19:26, Saurabh Sengar wrote: > If no primary handler is specified for threaded_irq then a > default one is assigned which always returns IRQ_WAKE_THREAD. > This handler requires the IRQF_ONESHOT, because the source of > interrupt is not disabled > > Signed-off-by: Saurabh Sengar Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/of_mmc_spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c > index 6e218fb..660170c 100644 > --- a/drivers/mmc/host/of_mmc_spi.c > +++ b/drivers/mmc/host/of_mmc_spi.c > @@ -55,8 +55,8 @@ static int of_mmc_spi_init(struct device *dev, > { > struct of_mmc_spi *oms = to_of_mmc_spi(dev); > > - return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0, > - dev_name(dev), mmc); > + return request_threaded_irq(oms->detect_irq, NULL, irqhandler, > + IRQF_ONESHOT, dev_name(dev), mmc); > } > > static void of_mmc_spi_exit(struct device *dev, void *mmc) > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/