Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbLDO4w (ORCPT ); Fri, 4 Dec 2015 09:56:52 -0500 Received: from mail-yk0-f172.google.com ([209.85.160.172]:35648 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbbLDO4t (ORCPT ); Fri, 4 Dec 2015 09:56:49 -0500 MIME-Version: 1.0 In-Reply-To: <1448971954-398-1-git-send-email-chaotian.jing@mediatek.com> References: <1448971954-398-1-git-send-email-chaotian.jing@mediatek.com> Date: Fri, 4 Dec 2015 15:56:48 +0100 Message-ID: Subject: Re: [PATCH] mmc: mediatek: change some dev_err to dev_dbg From: Ulf Hansson To: Chaotian Jing Cc: Matthias Brugger , linux-mmc , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , srv_heupstream , Daniel Kurtz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2371 Lines: 51 On 1 December 2015 at 13:12, Chaotian Jing wrote: > there are too many error logs shown when use CMD21/CMD19 to do tune, > and it will appear at each resume time, print out so many logs to the > uart console cost too mush time. so change it to dev_dbg. > > Signed-off-by: Chaotian Jing This one didn't apply to my next branch. Can you please rebase. Kind regards Uffe > --- > drivers/mmc/host/mtk-sd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 39568cc..34d23b8 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -972,7 +972,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events, > if ((events & MSDC_INT_XFER_COMPL) && (!stop || !stop->error)) { > data->bytes_xfered = data->blocks * data->blksz; > } else { > - dev_err(host->dev, "interrupt events: %x\n", events); > + dev_dbg(host->dev, "interrupt events: %x\n", events); > msdc_reset_hw(host); > host->error |= REQ_DAT_ERR; > data->bytes_xfered = 0; > @@ -982,10 +982,10 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events, > else if (events & MSDC_INT_DATCRCERR) > data->error = -EILSEQ; > > - dev_err(host->dev, "%s: cmd=%d; blocks=%d", > + dev_dbg(host->dev, "%s: cmd=%d; blocks=%d", > __func__, mrq->cmd->opcode, data->blocks); > - dev_err(host->dev, "data_error=%d xfer_size=%d\n", > - (int)data->error, data->bytes_xfered); > + dev_dbg(host->dev, "data_error=%d xfer_size=%d\n", > + (int)data->error, data->bytes_xfered); > } > > msdc_data_xfer_next(host, mrq, data); > -- > 1.8.1.1.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/