Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754934AbbLDPfe (ORCPT ); Fri, 4 Dec 2015 10:35:34 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29942 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083AbbLDPfa (ORCPT ); Fri, 4 Dec 2015 10:35:30 -0500 Subject: Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs To: David Vrabel , x86@kernel.org References: <1449139404-25101-1-git-send-email-david.vrabel@citrix.com> <56619DCE.3050900@citrix.com> <5661B033.10503@citrix.com> Cc: linux-kernel@vger.kernel.org, Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner From: Boris Ostrovsky Message-ID: <5661B2AD.3030808@oracle.com> Date: Fri, 4 Dec 2015 10:35:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5661B033.10503@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 43 On 12/04/2015 10:24 AM, David Vrabel wrote: > On 04/12/15 14:06, David Vrabel wrote: >> On 03/12/15 10:43, David Vrabel wrote: >>> Adding the rtc platform device when there are no legacy irqs (no >>> legacy PIC) causes a conflict with other devices that end up using the >>> same irq number. >> An alternative is to remove the rtc_cmos platform device in Xen PV >> guests. >> >> Any preference on how this regression should be fixed? >> >> David >> >> 8<-------------------------- >> x86: Xen PV guests don't have the rtc_cmos platform device >> > [...] >> --- a/arch/x86/kernel/rtc.c >> +++ b/arch/x86/kernel/rtc.c >> @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) >> } >> #endif >> >> + if (xen_pv_domain()) >> + return -ENODEV; >> + > Note there's a missing include that breaks !XEN builds. We could also use paravirt_enable() here which will probably cover HVMlite case as well. (Until we start turning on and off various HVMlite features). Don't know how it will affect lguest (which so far is the only other paravirt-enabled guest). -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/