Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329AbbLDPhk (ORCPT ); Fri, 4 Dec 2015 10:37:40 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:6951 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754106AbbLDPhh (ORCPT ); Fri, 4 Dec 2015 10:37:37 -0500 From: Josef Bacik To: , , Subject: [PATCH] trace-cmd: quiet some output when using libtracecmd Date: Fri, 4 Dec 2015 10:37:30 -0500 Message-ID: <1449243450-4280-1-git-send-email-jbacik@fb.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-04_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 50 If you link against libtracecmd you get a few extraneous warnings and printf's that aren't related to your tool. So by default make the path to the events you are tracing use pr_stat() so if it's not defined we don't get the output, and make the weak warning() do nothing by default. The trace-cmd stuff has this defined so it'll continue to work normally, it just won't be noisy for consumers of libtracecmd. Thanks, Signed-off-by: Josef Bacik --- parse-utils.c | 5 ----- trace-record.c | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/parse-utils.c b/parse-utils.c index c5b0487..9f9c0e9 100644 --- a/parse-utils.c +++ b/parse-utils.c @@ -63,11 +63,6 @@ void __warning(const char *fmt, ...) void __weak warning(const char *fmt, ...) { - va_list ap; - - va_start(ap, fmt); - __vwarning(fmt, ap); - va_end(ap); } void __vpr_stat(const char *fmt, va_list ap) diff --git a/trace-record.c b/trace-record.c index e4194b5..7d3ea37 100644 --- a/trace-record.c +++ b/trace-record.c @@ -2120,7 +2120,7 @@ static int expand_event_files(struct buffer_instance *instance, path = globbuf.gl_pathv[i]; event = create_event(instance, path, old_event); - printf("%s\n", path); + pr_stat("%s\n", path); len = strlen(path); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/