Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755366AbbLDQWs (ORCPT ); Fri, 4 Dec 2015 11:22:48 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:34253 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753534AbbLDQWo (ORCPT ); Fri, 4 Dec 2015 11:22:44 -0500 Subject: Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node To: bayi cheng , Daniel Kurtz References: <1447817403-16631-1-git-send-email-bayi.cheng@mediatek.com> <1447817403-16631-3-git-send-email-bayi.cheng@mediatek.com> <1448505773.9118.19.camel@mhfsdcap03> Cc: David Woodhouse , Brian Norris , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-mtd@lists.infradead.org, srv_heupstream , jteki@openedev.com, ezequiel@vanguardiasur.com.ar From: Matthias Brugger Message-ID: <5661BDCF.9020105@gmail.com> Date: Fri, 4 Dec 2015 17:22:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448505773.9118.19.camel@mhfsdcap03> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2466 Lines: 73 On 26/11/15 03:42, bayi cheng wrote: > On Thu, 2015-11-26 at 09:20 +0800, Daniel Kurtz wrote: >> Hi Bayi, Matthias, >> >> Sorry for the late review, one comment below... >> >> On Wed, Nov 18, 2015 at 11:30 AM, Bayi Cheng wrote: >>> Add Mediatek nor flash node >>> >>> Signed-off-by: Bayi Cheng >>> Acked-by: Brian Norris >>> --- >>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++- >>> 1 file changed, 17 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> index 4dd5f93..7988656 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> @@ -387,7 +387,23 @@ >>> status = "disabled"; >>> }; >>> >>> - i2c3: i2c@11010000 { >>> + nor_flash: spi@1100d000 { >>> + compatible = "mediatek,mt8173-nor"; >>> + reg = <0 0x1100d000 0 0xe0>; >>> + clocks = <&pericfg CLK_PERI_SPI>, >>> + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; >>> + clock-names = "spi", "sf"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "disabled"; >>> + >>> + flash@0 { >>> + compatible = "jedec,spi-nor"; >>> + reg = <0>; >>> + }; >> >> I think this flash@0 node represents the flash device present on the >> board and should therefore be moved to the board-specific .dts. >> >> -Dan >> Good catch, thanks. > Hi Daniel, Thanks for your comments, and I will fixed it in the next > patch. Ok, I dropped your patch in the meanwhile. Regards, Matthias >>> + }; >>> + >>> + i2c3: i2c3@11010000 { >>> compatible = "mediatek,mt8173-i2c"; >>> reg = <0 0x11010000 0 0x70>, >>> <0 0x11000280 0 0x80>; >>> -- >>> 1.8.1.1.dirty >>> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/