Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755546AbbLDQb5 (ORCPT ); Fri, 4 Dec 2015 11:31:57 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:35427 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803AbbLDQbz (ORCPT ); Fri, 4 Dec 2015 11:31:55 -0500 MIME-Version: 1.0 In-Reply-To: <20151204162314.GA31475@kroah.com> References: <20151202162924.GB32113@kroah.com> <1449076897-4617-1-git-send-email-saurabh.truth@gmail.com> <20151204162314.GA31475@kroah.com> Date: Fri, 4 Dec 2015 22:01:54 +0530 Message-ID: Subject: Re: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap From: Saurabh Sengar To: Greg KH Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 43 On 4 December 2015 at 21:53, Greg KH wrote: > On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> v2: changed logic a bit, because of recent patches pushed to usb-next >> drivers/usb/host/pci-quirks.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> index 26cb8c8..2ac198c 100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ b/drivers/usb/host/pci-quirks.c >> @@ -992,7 +992,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> if ((ext_cap_offset + sizeof(val)) > len) { >> /* We're reading garbage from the controller */ >> dev_warn(&pdev->dev, "xHCI controller failing to respond"); >> - return; >> + goto hc_init; > > Are you sure this is correct? That goto location then does a whole > bunch of things with the xhci controller that you just now determined is > failing to respond. I can't take this as-is, sorry. > > greg k-h Yes I agree, and in the first patch I didn't do this way. But the latest patch which got introduced is doing "goto hc_init" at line 990 ext_cap_offset = xhci_find_next_ext_cap(base, 0, XHCI_EXT_CAPS_LEGACY); if (!ext_cap_offset) goto hc_init; I think this is wrong too, may be I am wrong. Any way I will send the first patch again on top of usb-next as v3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/