Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752449AbbLDSJe (ORCPT ); Fri, 4 Dec 2015 13:09:34 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:48790 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbbLDSJc (ORCPT ); Fri, 4 Dec 2015 13:09:32 -0500 Date: Fri, 4 Dec 2015 11:09:20 -0700 From: Jason Gunthorpe To: "Wilck, Martin" Cc: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Uwe Kleine-K??nig Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151204180920.GA32292@obsidianresearch.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> <20151203170041.GA32175@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 33 On Fri, Dec 04, 2015 at 10:10:15AM +0100, Wilck, Martin wrote: > The following simple change fixes the ACPI probing after applying your > latest series. The must have been another ACPI resource that you were > erroneously using as mem resource. Close, acpi_dev_resource_memory destroys it's output parameter when it fails :( Should be: if (acpi_dev_resource_interrupt(ares, 0, &res)) tpm_info->irq = res.start; else if (acpi_dev_resource_memory(ares, &res)) tpm_info->res = res; > The IS_ERR change() didn't fix it. I think it's not needed, although it > probably can't hurt. IS_ERR should address the oops though?? I've put all the revised patches here: https://github.com/jgunthorpe/linux/commits/for-jarkko If you are OK with them now I'll post the series. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/