Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754954AbbLDVEk (ORCPT ); Fri, 4 Dec 2015 16:04:40 -0500 Received: from proxima.lp0.eu ([81.2.80.65]:57362 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754158AbbLDVEi (ORCPT ); Fri, 4 Dec 2015 16:04:38 -0500 Message-ID: <74d29bf38adc88b27811a70ed409e9182ddeb5b5@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid> In-Reply-To: <20151204143037.GA3667@rob-hp-laptop> References: <565CB727.7030209@simon.arlott.org.uk> <20151204143037.GA3667@rob-hp-laptop> Date: Fri, 4 Dec 2015 21:04:25 -0000 Subject: Re: [PATCH 1/2] clk: Add brcm,bcm63xx-gate-clk device tree binding From: "Simon Arlott" To: "Rob Herring" Cc: "Michael Turquette" , "Stephen Boyd" , "Kevin Cernekee" , "Florian Fainelli" , "devicetree@vger.kernel.org" , "Linux Kernel Mailing List" , linux-clk@vger.kernel.org, linux-mips@linux-mips.org, "Pawel Moll" , "Mark Rutland" , "Ian Campbell" , "Kumar Gala" User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3164 Lines: 57 On Fri, December 4, 2015 14:30, Rob Herring wrote: > On Mon, Nov 30, 2015 at 08:52:55PM +0000, Simon Arlott wrote: >> +periph_clk: periph_clk { >> + compatible = "brcm,bcm63168-gate-clk", "brcm,bcm63xx-gate-clk"; >> + regmap = <&periph_cntl>; > > What else is in periph_cntrl? Could this all just be part of that node? uint32 RevID; /* (00) word 0 */ uint32 blkEnables; /* (04) word 1 */ <-- gated clocks uint32 pll_control; /* (08) word 2 */ <-- system reset controller bit uint32 deviceTimeoutEn; /* (0c) word 3 */ <-- unknown uint32 softResetB; /* (10) word 4 */ <-- device reset controller bits uint32 diagControl; /* (14) word 5 */ <-- unknown uint32 ExtIrqCfg; /* (18) word 6*/ <-- external interrupt controller uint32 unused1; /* (1c) word 7 */ <-- (external interrupt controller?) IrqControl_t IrqControl[3]; /* (20) (40) (60) */ <-- normal interrupt controller So it has these clocks, two types of reset controller, and the interrupt controllers, but I've left the interrupt controllers registers out of the syscon device. For the registers in the "timer" peripheral at the end of the timer/watchdog registers: uint32 EnSwPLL; <-- unknown uint32 ClkRstCtl; #define POR_RESET_STATUS (1 << 31) <-- unknown #define HW_RESET_STATUS (1 << 30) <-- unknown #define SW_RESET_STATUS (1 << 29) <-- unknown #define USB_REF_CLKEN (1 << 18) <-- gated clock #define UTO_EXTIN_CLKEN (1 << 17) <-- gated clock #define UTO_CLK50_SEL (1 << 16) <-- looks like a clock frequency selection bit #define FAP2_PLL_CLKEN (1 << 15) <-- gated clock #define FAP2_PLL_FREQ_SHIFT 12 <-- bits for controlling the frequency #define FAP1_PLL_CLKEN (1 << 11) <-- gated clock #define FAP1_PLL_FREQ_SHIFT 8 <-- bits for controlling the frequency #define WAKEON_DSL (1 << 7) <-- wake on network bit #define WAKEON_EPHY (1 << 6) <-- wake on network bit #define DSL_ENERGY_DETECT_ENABLE (1 << 4) <-- energy saving control for network #define GPHY_1_ENERGY_DETECT_ENABLE (1 << 3) <-- energy saving control for network #define EPHY_3_ENERGY_DETECT_ENABLE (1 << 2) <-- energy saving control for network #define EPHY_2_ENERGY_DETECT_ENABLE (1 << 1) <-- energy saving control for network #define EPHY_1_ENERGY_DETECT_ENABLE (1 << 0) <-- energy saving control for network I need the usb_ref clock for USB, and I want to be able to disable uto_extin, fap1 and fap2 as they're unused by anything in the device tree. The full list of registers is here: https://github.com/lp0/bcm963xx_4.12L.06B_consumer/blob/master/shared/opensource/include/bcm963xx/63268_map_part.h -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/