Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095AbbLDVMV (ORCPT ); Fri, 4 Dec 2015 16:12:21 -0500 Received: from proxima.lp0.eu ([81.2.80.65]:57528 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbbLDVMU (ORCPT ); Fri, 4 Dec 2015 16:12:20 -0500 Message-ID: <6a3790afc811ac4ed732371f2eb33a7c194b996d@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid> In-Reply-To: <1449131943.3339.8.camel@pengutronix.de> References: <565F5C96.5090700@simon.arlott.org.uk> <1449131943.3339.8.camel@pengutronix.de> Date: Fri, 4 Dec 2015 21:12:10 -0000 Subject: Re: [PATCH (v2) 1/2] reset: Add brcm,bcm6345-reset device tree binding From: "Simon Arlott" To: "Rob Herring" , "Philipp Zabel" Cc: "Kevin Cernekee" , "Florian Fainelli" , "devicetree@vger.kernel.org" , linux-kernel@vger.kernel.org, "MIPS Mailing List" , "Pawel Moll" , "Mark Rutland" , "Ian Campbell" , "Sergei Shtylyov" User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 42 On Thu, December 3, 2015 08:39, Philipp Zabel wrote: > Am Mittwoch, den 02.12.2015, 21:03 +0000 schrieb Simon Arlott: >> +periph_soft_rst: reset-controller { >> + compatible = "brcm,bcm63168-reset", "brcm,bcm6345-reset"; >> + regmap = <&periph_cntl>; >> + offset = <0x10>; >> + >> + #reset-cells = <1>; >> +}; > > I would have written it something like this: > > periph_cntl: ... { > compatible = "syscon", "simple-mfd"; > #address-cells = <1>; > #size-cells = <1>; > > periph_soft_rst: reset-controller { > compatible = "brcm,bcm6345-reset"; > reg = <0x10 0x4>; > #reset-cells = <1>; > }; > }; > > for a device that is only controlled through a syscon. Rob, do you want me to change this or is my version ok? > The driver itself looks good to me. > > best regards > Philipp > > -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/