Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756521AbbLDVSj (ORCPT ); Fri, 4 Dec 2015 16:18:39 -0500 Received: from mail.kernel.org ([198.145.29.136]:50155 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756424AbbLDVSg (ORCPT ); Fri, 4 Dec 2015 16:18:36 -0500 Date: Fri, 4 Dec 2015 13:18:33 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to convert inline inode in ->setattr Message-ID: <20151204211833.GA73535@jaegeuk.local> References: <000001d12be9$87054960$950fdc20$@samsung.com> <20151204205523.GA73158@jaegeuk.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151204205523.GA73158@jaegeuk.local> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2769 Lines: 74 On Fri, Dec 04, 2015 at 12:55:23PM -0800, Jaegeuk Kim wrote: > Hi Chao, > > On Tue, Dec 01, 2015 at 11:36:16AM +0800, Chao Yu wrote: > > In commit 3c4541452748 ("f2fs: do not trim preallocated blocks when > > truncating after i_size"), in order to follow the regulation: "truncate(x) > > where x > i_size will not trim all blocks past i_size." like other file > > systems, in ->setattr we invoked truncate_setsize instead of f2fs_truncate > > to avoid unneeded block trimming in such case, but forgot to call > > f2fs_convert_inline_inode keep consistency of inline data conversion rule. > > > > This patch fixes to convert inline data if necessary. > > > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/file.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index 96e4e04..a018ed3 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -686,6 +686,14 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr) > > * larger than i_size. > > */ > > truncate_setsize(inode, attr->ia_size); > > + > > + /* should convert inline inode here */ > > + if (f2fs_has_inline_data(inode) && > > + !f2fs_may_inline_data(inode)) { > > + err = f2fs_convert_inline_inode(inode); > > + if (err) > > + return err; > > + } > > Without this, f2fs handles correctly inline_data when user tries to write > something later, right? > > One corner case is: > if the partiton is filled up to 100% with data + inline_data, we cannot truncate > one of inline_data after merging this patch. > Cause it failed to convert it. Oh, it turns out this is due to the error handling -ENOSPC of f2fs_truncate. For now, it seems there is no easy workaround this. Please ignore my concern. ;) Thanks, > > Thanks, > > > inode->i_mtime = inode->i_ctime = CURRENT_TIME; > > } > > } > > -- > > 2.6.3 > > > > ------------------------------------------------------------------------------ > Go from Idea to Many App Stores Faster with Intel(R) XDK > Give your users amazing mobile app experiences with Intel(R) XDK. > Use one codebase in this all-in-one HTML5 development environment. > Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. > http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/