Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756801AbbLDVxj (ORCPT ); Fri, 4 Dec 2015 16:53:39 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:44767 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755358AbbLDVxh (ORCPT ); Fri, 4 Dec 2015 16:53:37 -0500 Date: Fri, 04 Dec 2015 16:53:34 -0500 (EST) Message-Id: <20151204.165334.1119277452308794437.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: eric.dumazet@gmail.com, phil@nwl.cc, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tgraf@suug.ch, fengguang.wu@intel.com, wfg@linux.intel.com, lkp@01.org Subject: Re: rhashtable: Use __vmalloc with GFP_ATOMIC for table allocation From: David Miller In-Reply-To: <20151204143956.GA17471@gondor.apana.org.au> References: <20151203125117.GB5505@gondor.apana.org.au> <1449158919.6379.27.camel@edumazet-glaptop2.roam.corp.google.com> <20151204143956.GA17471@gondor.apana.org.au> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Dec 2015 13:53:37 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 22 From: Herbert Xu Date: Fri, 4 Dec 2015 22:39:56 +0800 > When an rhashtable user pounds rhashtable hard with back-to-back > insertions we may end up growing the table in GFP_ATOMIC context. > Unfortunately when the table reaches a certain size this often > fails because we don't have enough physically contiguous pages > to hold the new table. > > Eric Dumazet suggested (and in fact wrote this patch) using > __vmalloc instead which can be used in GFP_ATOMIC context. > > Reported-by: Phil Sutter > Suggested-by: Eric Dumazet > Signed-off-by: Herbert Xu Applied, thanks Herbert. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/