Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756743AbbLDVyq (ORCPT ); Fri, 4 Dec 2015 16:54:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:53896 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375AbbLDVyo (ORCPT ); Fri, 4 Dec 2015 16:54:44 -0500 Date: Fri, 4 Dec 2015 22:54:43 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Josh Poimboeuf cc: Seth Jennings , Vojtech Pavlik , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Rusty Russell , Miroslav Benes Subject: Re: [PATCH v4] livepatch: Cleanup module page permission changes In-Reply-To: <9b321c4c2edeaff43f21040a883891a691fc1978.1449181535.git.jpoimboe@redhat.com> Message-ID: References: <9b321c4c2edeaff43f21040a883891a691fc1978.1449181535.git.jpoimboe@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 31 On Thu, 3 Dec 2015, Josh Poimboeuf wrote: > Calling set_memory_rw() and set_memory_ro() for every iteration of the > loop in klp_write_object_relocations() is messy, inefficient, and > error-prone. > > Change all the read-only pages to read-write before the loop and convert > them back to read-only again afterwards. > > Suggested-by: Miroslav Benes > Signed-off-by: Josh Poimboeuf > --- > Based on the following branches: > - git://git.kernel.org/pub/scm/linux/kernel/git/jikos/livepatching.git for-4.5/core > - git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git modules-next > > - v4: rebase onto Chris's sympos changes > - v3: use new module_{disable,enable}_ro() functions (in linux-next) Merged together with patches from Rusty's modules-next and applied to for-4.5/core. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/