Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756895AbbLDWBa (ORCPT ); Fri, 4 Dec 2015 17:01:30 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:44962 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755395AbbLDWB2 (ORCPT ); Fri, 4 Dec 2015 17:01:28 -0500 Date: Fri, 04 Dec 2015 17:01:25 -0500 (EST) Message-Id: <20151204.170125.1062807391042745453.davem@davemloft.net> To: pavel@ucw.cz Cc: eric.dumazet@gmail.com, mhocko@kernel.org, akpm@osdl.org, linux-kernel@vger.kernel.org, jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org, rjw@rjwysocki.net, linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com, ebiederm@xmission.com Subject: Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation From: David Miller In-Reply-To: <20151204213027.GA6397@amd> References: <20151204081127.GA29367@amd> <20151204.112140.1465149588813636971.davem@davemloft.net> <20151204213027.GA6397@amd> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Dec 2015 14:01:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 38 From: Pavel Machek Date: Fri, 4 Dec 2015 22:30:27 +0100 > On Fri 2015-12-04 11:21:40, David Miller wrote: >> From: Pavel Machek >> Date: Fri, 4 Dec 2015 09:11:27 +0100 >> >> >> >> if (unlikely(!ring_header->desc)) { >> >> >> - dev_err(&pdev->dev, "pci_alloc_consistend failed\n"); >> >> >> + dev_err(&pdev->dev, "could not get memory for DMA buffer\n"); >> >> >> goto err_nomem; >> >> >> } >> >> >> memset(ring_header->desc, 0, ring_header->size); >> >> >> >> >> >> >> >> > >> >> > So this memset() will really require a different patch to get removed ? >> >> > >> >> > Sigh, not sure why I review patches. >> >> >> >> Agreed, please use dma_zalloc_coherent() and kill that memset(). >> > >> > Ok, updated. I'll also add cc: stable, because it makes notebooks with >> > affected chipset unusable. >> >> Networking patches do not use CC: stable, instead you simply ask me >> to queue it up and then I batch submit networking fixes to -stable >> periodically myself. > > Ok, can you take the patch and ignore the Cc, or should I do one more > iteration? I took care of it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/