Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932254AbbLEBC3 (ORCPT ); Fri, 4 Dec 2015 20:02:29 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34244 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932107AbbLEBC0 (ORCPT ); Fri, 4 Dec 2015 20:02:26 -0500 Date: Fri, 4 Dec 2015 17:02:21 -0800 From: Josh Triplett To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 5/8] rcutorture: Print symbolic name for rcu_torture_writer_state Message-ID: <20151205010221.GB27128@cloud> References: <20151205002331.GA27249@linux.vnet.ibm.com> <1449275032-28206-5-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449275032-28206-5-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2134 Lines: 66 On Fri, Dec 04, 2015 at 04:23:49PM -0800, Paul E. McKenney wrote: > Currently, rcu_torture_writer_state is printed as an integer, which slows > debugging. This commit therefore prints a symbolic name in addition to > the integer. > > Signed-off-by: Paul E. McKenney > --- > kernel/rcu/rcutorture.c | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c > index d89328e260df..adbb194e2b5d 100644 > --- a/kernel/rcu/rcutorture.c > +++ b/kernel/rcu/rcutorture.c > @@ -162,6 +162,27 @@ static int rcu_torture_writer_state; > #define RTWS_SYNC 7 > #define RTWS_STUTTER 8 > #define RTWS_STOPPING 9 > +static char * const rcu_torture_writer_state_names[] = { Shouldn't this use "static const char * const"? Also, see below. > + "RTWS_FIXED_DELAY", > + "RTWS_DELAY", > + "RTWS_REPLACE", > + "RTWS_DEF_FREE", > + "RTWS_EXP_SYNC", > + "RTWS_COND_GET", > + "RTWS_COND_SYNC", > + "RTWS_SYNC", > + "RTWS_STUTTER", > + "RTWS_STOPPING", > +}; > + > +char *rcu_torture_writer_state_getname(void) This should return "const char *", I think. > +{ > + unsigned int i = READ_ONCE(rcu_torture_writer_state); > + > + if (i >= ARRAY_SIZE(rcu_torture_writer_state_names)) > + return "???"; > + return rcu_torture_writer_state_names[i]; > +} > > #if defined(MODULE) || defined(CONFIG_RCU_TORTURE_TEST_RUNNABLE) > #define RCUTORTURE_RUNNABLE_INIT 1 > @@ -1307,7 +1328,8 @@ rcu_torture_stats_print(void) > > rcutorture_get_gp_data(cur_ops->ttype, > &flags, &gpnum, &completed); > - pr_alert("??? Writer stall state %d g%lu c%lu f%#x\n", > + pr_alert("??? Writer stall state %s(%d) g%lu c%lu f%#x\n", > + rcu_torture_writer_state_getname(), > rcu_torture_writer_state, > gpnum, completed, flags); > show_rcu_gp_kthreads(); > -- > 2.5.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/