Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141AbbLECMZ (ORCPT ); Fri, 4 Dec 2015 21:12:25 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:42103 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbbLECMX (ORCPT ); Fri, 4 Dec 2015 21:12:23 -0500 Date: Sat, 5 Dec 2015 13:12:12 +1100 (AEDT) From: Finn Thain To: Julian Calaby cc: Ondrej Zary , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi , linux-kernel Subject: Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips In-Reply-To: Message-ID: References: <20151118083455.331768508@telegraphics.com.au> <1449183781-2163-1-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 34 On Sat, 5 Dec 2015, Julian Calaby wrote: > Hi Finn, > > On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain wrote: > > > > On Fri, 4 Dec 2015, Julian Calaby wrote: > > > >> > - if (overrides[current_override].board == BOARD_NCR53C400A) { > >> > + if (overrides[current_override].board == BOARD_NCR53C400A || > >> > + overrides[current_override].board == BOARD_DTC3181E) { > >> > >> These if statements are starting to get a bit long, would it make > >> sense to replace them with a flag or equivalent? > > > > To what end? Shorter lines? As in, > > Pretty much, each expression is quite long and they seem to be growing > fairly rapidly as you and Ondrej discover similar boards. Each BOARD_* macro actually refers to a whole category of devices. No new boards, devices or categories of devices have been discovered. Ondrej is enabling and/or fixing PDMA functionality for three existing device categories, for which the driver already has a nominally compatible PDMA implementation. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/