Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbbLECiZ (ORCPT ); Fri, 4 Dec 2015 21:38:25 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:34940 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088AbbLECiX (ORCPT ); Fri, 4 Dec 2015 21:38:23 -0500 MIME-Version: 1.0 In-Reply-To: References: <20151118083455.331768508@telegraphics.com.au> <1449183781-2163-1-git-send-email-linux@rainbow-software.org> From: Julian Calaby Date: Sat, 5 Dec 2015 13:38:03 +1100 Message-ID: Subject: Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips To: Finn Thain Cc: Ondrej Zary , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 47 Hi Finn, On Sat, Dec 5, 2015 at 1:12 PM, Finn Thain wrote: > > On Sat, 5 Dec 2015, Julian Calaby wrote: > >> Hi Finn, >> >> On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain wrote: >> > >> > On Fri, 4 Dec 2015, Julian Calaby wrote: >> > >> >> > - if (overrides[current_override].board == BOARD_NCR53C400A) { >> >> > + if (overrides[current_override].board == BOARD_NCR53C400A || >> >> > + overrides[current_override].board == BOARD_DTC3181E) { >> >> >> >> These if statements are starting to get a bit long, would it make >> >> sense to replace them with a flag or equivalent? >> > >> > To what end? Shorter lines? As in, >> >> Pretty much, each expression is quite long and they seem to be growing >> fairly rapidly as you and Ondrej discover similar boards. > > Each BOARD_* macro actually refers to a whole category of devices. No new > boards, devices or categories of devices have been discovered. > > Ondrej is enabling and/or fixing PDMA functionality for three existing > device categories, for which the driver already has a nominally compatible > PDMA implementation. I meant discovering boards which are similar. Either way, I'm not sure it matters that much. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/