Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701AbbLEGQy (ORCPT ); Sat, 5 Dec 2015 01:16:54 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:34507 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbbLEGQw (ORCPT ); Sat, 5 Dec 2015 01:16:52 -0500 From: Seth Forshee To: Alexander Viro Cc: Seth Forshee , "Serge E. Hallyn" , "Theodore Ts'o" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fs: Drop CAP_SYS_RAWIO requirement for FIBMAP Date: Sat, 5 Dec 2015 00:15:16 -0600 Message-Id: <1449296116-14527-1-git-send-email-seth.forshee@canonical.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 37 The information exposed by FIBMAP is not privileged and is similar to the information provided by FIEMAP, which does not require privileges. According to [1] the reason the capability check was originally added was to prevent crashing the kernel by passing invalid arguments, but this should no longer be a problem, so this requirement can be removed. [1] http://www.gossamer-threads.com/lists/linux/kernel/103611 Cc: "Serge E. Hallyn" Cc: Theodore Ts'o Signed-off-by: Seth Forshee --- fs/ioctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index 5d01d2638ca5..c963d82b0de8 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -55,8 +55,6 @@ static int ioctl_fibmap(struct file *filp, int __user *p) /* do we support this mess? */ if (!mapping->a_ops->bmap) return -EINVAL; - if (!capable(CAP_SYS_RAWIO)) - return -EPERM; res = get_user(block, p); if (res) return res; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/