Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbbLEKFG (ORCPT ); Sat, 5 Dec 2015 05:05:06 -0500 Received: from mga09.intel.com ([134.134.136.24]:39271 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753317AbbLEKFD (ORCPT ); Sat, 5 Dec 2015 05:05:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,384,1444719600"; d="scan'208";a="854489605" Date: Sat, 5 Dec 2015 15:38:04 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: swarren@wwwdotorg.org, lee@kernel.org, eric@anholt.net, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool Message-ID: <20151205100804.GY1854@localhost> References: <1447672143-14201-1-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447672143-14201-1-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 19 On Mon, Nov 16, 2015 at 01:09:03PM +0200, Peter Ujfalusi wrote: > f93178291712 dmaengine: bcm2835-dma: Fix memory leak when stopping a > running transfer > > Fixed the memleak, but introduced another issue: the terminate_all callback > might be called with interrupts disabled and the dma_free_coherent() is > not allowed to be called when IRQs are disabled. > Convert the driver to use dma_pool_* for managing the list of control > blocks for the transfer. Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/