Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753734AbbLEKOj (ORCPT ); Sat, 5 Dec 2015 05:14:39 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:33972 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352AbbLEKOi convert rfc822-to-8bit (ORCPT ); Sat, 5 Dec 2015 05:14:38 -0500 From: Vineet Gupta To: Alexey Brodkin , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "Nelson Pereira" , Joao Pinto Subject: Re: [PATCH] ARC: [axs10x] enable DW DMA controller Thread-Topic: [PATCH] ARC: [axs10x] enable DW DMA controller Thread-Index: AQHRLskYIs1dA874BkWLBkpxMkSKmg== Date: Sat, 5 Dec 2015 10:14:32 +0000 Message-ID: References: <1449256926-16786-1-git-send-email-abrodkin@synopsys.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3390 Lines: 107 On Saturday 05 December 2015 12:52 AM, Alexey Brodkin wrote: > From: Nelson Pereira > > ARC SDP baseboard among other peripherals sports > DesignWare DMA controller. > > This enables support of that device. > Note typically DW DMA controller is used with external devices > connected to ARC SDP board via HAPS Extension bus. Such a board config needs to have it's own defconfig / DT (if needed). There's no point in enabling this for rest of the world who don't have a use case for this IP. So nack ! -Vineet > > Signed-off-by: Nelson Pereira > Cc: Vineet Gupta > Signed-off-by: Alexey Brodkin > --- > arch/arc/boot/dts/axs10x_mb.dtsi | 16 ++++++++++++++++ > arch/arc/configs/axs101_defconfig | 5 +++++ > arch/arc/configs/axs103_defconfig | 5 +++++ > arch/arc/configs/axs103_smp_defconfig | 5 +++++ > 4 files changed, 31 insertions(+) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index f3db321..1e57580 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -220,5 +220,21 @@ > reg = <2>; > }; > }; > + > + dmac: dmac@0x80000 { > + compatible = "snps,dma-spear1340"; > + reg = <0x80000 0x1000>; > + interrupts = <9>; > + dma-channels = <4>; > + dma-requests = <16>; > + dma-masters = <2>; > + #dma-cells = <3>; > + chan_allocation_order = <1>; > + chan_priority = <1>; > + block_size = <0xfff>; > + data_width = <3 3>; > + clocks = <&apbclk>; > + clock-names = "hclk"; > + }; > }; > }; > diff --git a/arch/arc/configs/axs101_defconfig b/arch/arc/configs/axs101_defconfig > index 562dac6..405474f 100644 > --- a/arch/arc/configs/axs101_defconfig > +++ b/arch/arc/configs/axs101_defconfig > @@ -90,6 +90,11 @@ CONFIG_MMC_SDHCI=y > CONFIG_MMC_SDHCI_PLTFM=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > +CONFIG_DMADEVICES=y > +CONFIG_DW_DMAC_CORE=y > +CONFIG_DW_DMAC=y > +CONFIG_DMA_ENGINE=y > +CONFIG_DMA_OF=y > # CONFIG_IOMMU_SUPPORT is not set > CONFIG_EXT3_FS=y > CONFIG_EXT4_FS=y > diff --git a/arch/arc/configs/axs103_defconfig b/arch/arc/configs/axs103_defconfig > index 83a6d8d..570f06f 100644 > --- a/arch/arc/configs/axs103_defconfig > +++ b/arch/arc/configs/axs103_defconfig > @@ -96,6 +96,11 @@ CONFIG_MMC_SDHCI=y > CONFIG_MMC_SDHCI_PLTFM=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > +CONFIG_DMADEVICES=y > +CONFIG_DW_DMAC_CORE=y > +CONFIG_DW_DMAC=y > +CONFIG_DMA_ENGINE=y > +CONFIG_DMA_OF=y > # CONFIG_IOMMU_SUPPORT is not set > CONFIG_EXT3_FS=y > CONFIG_EXT4_FS=y > diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig > index f1e1c84..16cfce8 100644 > --- a/arch/arc/configs/axs103_smp_defconfig > +++ b/arch/arc/configs/axs103_smp_defconfig > @@ -97,6 +97,11 @@ CONFIG_MMC_SDHCI=y > CONFIG_MMC_SDHCI_PLTFM=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > +CONFIG_DMADEVICES=y > +CONFIG_DW_DMAC_CORE=y > +CONFIG_DW_DMAC=y > +CONFIG_DMA_ENGINE=y > +CONFIG_DMA_OF=y > # CONFIG_IOMMU_SUPPORT is not set > CONFIG_EXT3_FS=y > CONFIG_EXT4_FS=y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/