Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754501AbbLERVk (ORCPT ); Sat, 5 Dec 2015 12:21:40 -0500 Received: from mail-ig0-f182.google.com ([209.85.213.182]:36817 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbbLERVi (ORCPT ); Sat, 5 Dec 2015 12:21:38 -0500 Subject: Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function To: Soren Brinkmann , Greg Kroah-Hartman References: <1448161172-19717-1-git-send-email-soren.brinkmann@xilinx.com> <1448161172-19717-6-git-send-email-soren.brinkmann@xilinx.com> Cc: Jiri Slaby , Michal Simek , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <56631D1E.8050406@hurleysoftware.com> Date: Sat, 5 Dec 2015 12:21:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1448161172-19717-6-git-send-email-soren.brinkmann@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 15 On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > The startup function is supposed to initialize the UART for receiving. > Hence, don't enable the TX part. Also, protect HW accesses with the port > lock. Reviewed-by: Peter Hurley NB: the request_irq() should be _after_ h/w programming, otherwise an interrupt could be triggered and in-progress before the h/w has been setup. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/