Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbbLEVrU (ORCPT ); Sat, 5 Dec 2015 16:47:20 -0500 Received: from mail-bl2nam02on0067.outbound.protection.outlook.com ([104.47.38.67]:52904 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751746AbbLEVrT (ORCPT ); Sat, 5 Dec 2015 16:47:19 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Sat, 5 Dec 2015 13:47:09 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Peter Hurley CC: Greg Kroah-Hartman , Jiri Slaby , Michal Simek , , , Subject: Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function Message-ID: <20151205214709.GM4900@xsjsorenbubuntu> References: <1448161172-19717-1-git-send-email-soren.brinkmann@xilinx.com> <1448161172-19717-6-git-send-email-soren.brinkmann@xilinx.com> <56631D1E.8050406@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56631D1E.8050406@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21982.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(52604005)(377424004)(199003)(479174004)(24454002)(189002)(377454003)(50466002)(23676002)(33716001)(106466001)(57986006)(77096005)(47776003)(2950100001)(4001350100001)(19580405001)(83506001)(11100500001)(85182001)(87936001)(19580395003)(33656002)(6806005)(63266004)(81156007)(110136002)(50986999)(36386004)(1076002)(5008740100001)(92566002)(1220700001)(189998001)(86362001)(76176999)(5001960100002)(76506005)(85202003)(586003)(1096002)(54356999)(107986001)(217873001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1NAM02HT176;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:SN1NAM02HT176; X-Microsoft-Antispam-PRVS: <652b0f8ed5804038bc9492058f7f0478@SN1NAM02HT176.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1NAM02HT176;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM02HT176; X-Forefront-PRVS: 07817FCC2D X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2015 21:47:16.0556 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT176 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 20 On Sat, 2015-12-05 at 12:21PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > The startup function is supposed to initialize the UART for receiving. > > Hence, don't enable the TX part. Also, protect HW accesses with the port > > lock. > > Reviewed-by: Peter Hurley > > NB: the request_irq() should be _after_ h/w programming, otherwise an > interrupt could be triggered and in-progress before the h/w has been > setup. Thanks for pointing that out. I'll patch that. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/