Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbbLEXpf (ORCPT ); Sat, 5 Dec 2015 18:45:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39838 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbLEXpd (ORCPT ); Sat, 5 Dec 2015 18:45:33 -0500 Date: Sat, 05 Dec 2015 18:45:20 -0500 (EST) Message-Id: <20151205.184520.1281826797997335875.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: santosh@chelsio.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] cxgb3: Convert simple_strtoul to kstrtox From: David Miller In-Reply-To: <1449239201-879-1-git-send-email-clabbe.montjoie@gmail.com> References: <1449239201-879-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 05 Dec 2015 15:45:33 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 635 Lines: 16 From: LABBE Corentin Date: Fri, 4 Dec 2015 15:26:40 +0100 > the simple_strtoul function is obsolete. This patch replace it by > kstrtox. > > Signed-off-by: LABBE Corentin Again, kstrtouint() provides a reasonable error code, therefore when you do these conversions you should use that error code rather than hardcoded -EWHATEVER. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/