Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754462AbbLFEj7 (ORCPT ); Sat, 5 Dec 2015 23:39:59 -0500 Received: from mail-bl2nam02on0055.outbound.protection.outlook.com ([104.47.38.55]:54984 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754082AbbLFEjy (ORCPT ); Sat, 5 Dec 2015 23:39:54 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; ettus.com; dkim=none (message not signed) header.d=none;ettus.com; dmarc=bestguesspass action=none header.from=xilinx.com; From: Soren Brinkmann To: Greg Kroah-Hartman , Jiri Slaby CC: Michal Simek , , , , "Peter Hurley" , Moritz Fischer , Soren Brinkmann Subject: [PATCH LINUX v4 00/13] tty: xuartps: Fix lock ups Date: Sat, 5 Dec 2015 20:39:16 -0800 Message-ID: <1449376769-13369-1-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.6.3.3.g9bb996a MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21982.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(164054003)(199003)(63266004)(11100500001)(81156007)(47776003)(15975445007)(1220700001)(5008740100001)(5820100001)(4001430100002)(1096002)(92566002)(5001770100001)(107886002)(50466002)(36386004)(50986999)(6806005)(57986006)(33646002)(5001960100002)(86362001)(50226001)(106466001)(76506005)(77096005)(23676002)(189998001)(229853001)(586003)(87936001)(19580395003)(36756003)(107986001)(217873001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2NAM02HT048;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BL2NAM02HT048; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046);SRVR:BL2NAM02HT048;BCL:0;PCL:0;RULEID:;SRVR:BL2NAM02HT048; X-Forefront-PRVS: 0782EC617F X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2015 04:39:51.4144 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT048 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 44 Hi, I picked up all the review tags from Peter and Moritz and addressed Peter's comments. Most patches are unchanged but I added the info Peter suggested/provided to some commit messages. The patches "tty: xuartps: Move request_irq to after setting up the HW", "tty: xuartps: Improve sysrq handling" and "tty: xuartps: Remove '_OFFSET' suffix from #defines" are new, implementing the suggestions Peter made in the v3 review (https://lkml.org/lkml/2015/11/21/172). I pretty much rewrote "tty: xuartps: Refactor IRQ handling" (was: "tty: xuartps: Only handle RX IRQs when RX is enabled"). Instead of adding a flag, we now disable/enable the RX interrupts together with the receiver. That should prevent the RX lock ups I saw. Thanks, Sören Sören Brinkmann (13): tty: xuartps: Beautify read-modify writes tty: xuartps: Use spinlock to serialize HW access tty: xuartps: Don't consider circular buffer when enabling transmitter tty: xuartps: Clear interrupt status register in shutdown tty: xuartps: Improve startup function tty: xuartps: Move request_irq to after setting up the HW tty: xuartps: Keep lock for whole ISR tty: xuartps: Acquire port lock for shutdown tty: xuartps: Move RX path into helper function tty: xuartps: Refactor IRQ handling tty: xuartps: Cleanup: Reformat if-else tty: xuartps: Improve sysrq handling tty: xuartps: Remove '_OFFSET' suffix from #defines drivers/tty/serial/xilinx_uartps.c | 451 ++++++++++++++++++------------------- 1 file changed, 224 insertions(+), 227 deletions(-) -- 2.6.3.3.g9bb996a -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/