Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbbLFIm4 (ORCPT ); Sun, 6 Dec 2015 03:42:56 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:34256 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbbLFImy (ORCPT ); Sun, 6 Dec 2015 03:42:54 -0500 MIME-Version: 1.0 In-Reply-To: References: <20151118083455.331768508@telegraphics.com.au> <1449262855-4538-1-git-send-email-linux@rainbow-software.org> Date: Sun, 6 Dec 2015 09:42:53 +0100 X-Google-Sender-Auth: lhosTgBHPF_wDNgDXJqO9h2yJzg Message-ID: Subject: Re: [PATCH 73/71] ncr5380: Use runtime register mapping From: Geert Uytterhoeven To: Finn Thain Cc: Ondrej Zary , Michael Schmitz , "Linux/m68k" , scsi , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 23 On Sun, Dec 6, 2015 at 4:39 AM, Finn Thain wrote: >> - while (NCR5380_read(C400_CONTROL_STATUS_REG) & CSR_HOST_BUF_NOT_RDY); >> + while (NCR5380_read(hostdata->c400_ctl_status) & CSR_HOST_BUF_NOT_RDY); > > The semicolon should appear on the next line where it is more visible. And adding a cpu_relax() to the empty loop body is another good visual cue. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/