Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbbLFS3i (ORCPT ); Sun, 6 Dec 2015 13:29:38 -0500 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:62921 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753534AbbLFS3g (ORCPT ); Sun, 6 Dec 2015 13:29:36 -0500 X-IronPort-AV: E=Sophos;i="5.20,391,1444719600"; d="scan'208";a="82569139" Subject: Re: [PATCH v4 1/5] dt-bindings: add SMP enable-method for Broadcom NSP To: Rob Herring References: <1448987049-17041-1-git-send-email-kapilh@broadcom.com> <1448987049-17041-2-git-send-email-kapilh@broadcom.com> <20151202152604.GA20467@rob-hp-laptop> <565F16F1.9070809@broadcom.com> CC: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ray Jui , Scott Branden , Jon Mason , Florian Fainelli , "Gregory Fong" , Lee Jones , Hauke Mehrtens , Kever Yang , Maxime Ripard , Olof Johansson , "Paul Walmsley" , Linus Walleij , Chen-Yu Tsai , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" From: Kapil Hali Message-ID: <56647E88.6040002@broadcom.com> Date: Sun, 6 Dec 2015 23:59:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2602 Lines: 61 Hi Rob, On 12/6/2015 6:22 AM, Rob Herring wrote: > On Wed, Dec 2, 2015 at 10:06 AM, Kapil Hali wrote: >> Hi Rob, >> >> On 12/2/2015 8:56 PM, Rob Herring wrote: >>> On Tue, Dec 01, 2015 at 11:24:05AM -0500, Kapil Hali wrote: >>>> Add a compatible string "brcm,bcm-nsp-smp" for Broadcom's >>>> Northstar Plus CPU to the 32-bit ARM CPU device tree binding >>>> documentation file and create a new binding documentation for >>>> Northstar Plus CPU. >>>> >>>> Signed-off-by: Kapil Hali >>>> --- >>>> .../bindings/arm/bcm/brcm,nsp-cpu-method.txt | 39 ++++++++++++++++++++++ >>>> Documentation/devicetree/bindings/arm/cpus.txt | 1 + >>>> 2 files changed, 40 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt >>>> new file mode 100644 >>>> index 0000000..bf08872 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt >>>> @@ -0,0 +1,39 @@ >>>> +Broadcom Northstar Plus SoC CPU Enable Method >>>> +--------------------------------------------- >>>> +This binding defines the enable method used for starting secondary >>>> +CPUs in the following Broadcom SoCs: >>>> + BCM58522, BCM58525, BCM58535, BCM58622, BCM58623, BCM58625, BCM88312 >>>> + >>>> +The enable method is specified by defining the following required >>>> +properties in the "cpus" device tree node: >>>> + - enable-method = "brcm,bcm-nsp-smp"; >>>> + - secondary-boot-reg = <...>; >>> >>> Both of these are supposed to be per cpu core. >> >> 'enable-method' if not found in 'cpu' node is looked at in the 'cpus' >> node. Except for two-three SoC families, 'enable-method' is within >> 'cpus' node. Is my interpretation incorrect? Did I miss anything here? > > I'm not sure how you counted, but it is much more than 2-3 that are > correct (including all of PPC). It is quite mixed in dts files, but it > is documented to be per cpu node, so lets follow the documentation > please. > > Rob > I looked at arch/arm/* and not other arch types. But, as you said, let us keep it how it is in documentation and I have already updated latest patch set reflecting this change. Thanks, Kapil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/