Date: Mon, 7 Dec 2015 02:41:10 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RESEND] ARM: dts: kirkwood: Add DTS for Zyxel NSA325
Message-ID: <20151207014110.GB19715@lunn.ch>
References: <1449334057-6008-1-git-send-email-ulli.kroll@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449334057-6008-1-git-send-email-ulli.kroll@googlemail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1037
Lines: 42

> +		serial@12000 {
> +			status = "ok";
> +		};
> +
> +		sata@80000 {
> +			status = "okay";
> +			nr-ports = <2>;
> +		};
> +	};
> +
> +		gpio-leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_led_hdd2_green &pmx_led_hdd2_red
> +			     &pmx_led_usb_green
> +			     &pmx_led_sys_green &pmx_led_sys_orange
> +			     &pmx_led_copy_green &pmx_led_copy_red
> +			     &pmx_led_hdd1_green &pmx_led_hdd1_red>;
> +		pinctrl-names = "default";

Hi Hans

There is some odd indentation going on here, and in other parts of the
file.

> +
> +&nand {
> +	status = "okay";
> +	chip-delay = <35>;
> +
> +	partition@0 {
> +		label = "uboot";
> +		reg = <0x0000000 0x0100000>;
> +	};

The partitions should be inside a partitions node. See
Documentation/devicetree/bindings/mtd/partition.txt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/