Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755412AbbLGDOH (ORCPT ); Sun, 6 Dec 2015 22:14:07 -0500 Received: from ozlabs.org ([103.22.144.67]:48158 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755343AbbLGDNg (ORCPT ); Sun, 6 Dec 2015 22:13:36 -0500 From: Rusty Russell To: Ingo Molnar Cc: Steven Rostedt , LKML , Peter Zijlstra , Andrew Morton , Sergey Senozhatsky , Xunlei Pang Subject: Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero In-Reply-To: <20151206172936.GA29582@gmail.com> References: <20151203172428.600f380a@gandalf.local.home> <87lh9b573j.fsf@rustcorp.com.au> <20151203213745.52f21886@gandalf.local.home> <20151204073437.GA24827@gmail.com> <877fku553z.fsf@rustcorp.com.au> <20151206172936.GA29582@gmail.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 07 Dec 2015 12:26:23 +1030 Message-ID: <87bna3rph4.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 21 Ingo Molnar writes: > * Rusty Russell wrote: >> I don't think there are great answers here. But adding more subtle zeroing >> semantics feels wrong, even if it will mostly Just Work. > > It's not subtle if the naming clearly reflects it (hence my suggestion to rename > the API) - and the status quo for on-stack allocations is zeroing anyway, so it's > not a big jump... True, but we already have zalloc_cpumask_var() though if we want that? It probably makes sense to just switch everyone to that and get rid of the non-z one? Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/