Message-ID: <1449459120.7356.14.camel@perches.com>
Subject: Re: [PATCH net-next] net: hns: optimize XGE capability by reducing
 cpu usage
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, yankejian@huawei.com
Cc: lisheng011@huawei.com, lipeng321@huawei.com, salil.mehta@huawei.com,
        huangdaode@hisilicon.com, xuwei5@hisilicon.com, liguozhu@huawei.com,
        haifeng.wei@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sun, 06 Dec 2015 19:32:00 -0800
In-Reply-To: <20151206.222929.804694720513782203.davem@davemloft.net>
References: <1449300749-50275-1-git-send-email-yankejian@huawei.com>
	 <20151206.222929.804694720513782203.davem@davemloft.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 27

On Sun, 2015-12-06 at 22:29 -0500, David Miller wrote:
> From: yankejian <yankejian@huawei.com>
> Date: Sat, 5 Dec 2015 15:32:29 +0800
> 
> > +#if (PAGE_SIZE < 8192)
> > +?????if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) {
> > +?????????????truesize = hnae_buf_size(ring);
> > +?????} else {
> > +?????????????truesize = ALIGN(size, L1_CACHE_BYTES);
> > +?????????????last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
> > +?????}
> > +
> > +#else
> > +?????????????truesize = ALIGN(size, L1_CACHE_BYTES);
> > +?????????????last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
> > +#endif
> 
> This is not indented properly, and it looks terrible.

And it makes one curious as to why last_offset isn't set
in the first block.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/