Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755521AbbLGDd5 (ORCPT ); Sun, 6 Dec 2015 22:33:57 -0500 Received: from mail4.hitachi.co.jp ([133.145.228.5]:55104 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbbLGDd4 (ORCPT ); Sun, 6 Dec 2015 22:33:56 -0500 From: =?utf-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= To: "'Wang Nan'" , "acme@redhat.com" , "acme@kernel.org" , "namhyung@kernel.org" CC: "linux-kernel@vger.kernel.org" , "pi3orama@163.com" , "lizefan@huawei.com" Subject: RE: [PATCH resend] perf machine: Pass correct string to dso__adjust_kmod_long_name Thread-Topic: [PATCH resend] perf machine: Pass correct string to dso__adjust_kmod_long_name Thread-Index: AQHRMJgdRlY99xnzWUyTMsVCd0H4uJ6+3YkA Date: Mon, 7 Dec 2015 03:33:53 +0000 Message-ID: <50399556C9727B4D88A595C8584AAB3752645EAB@GSjpTKYDCembx32.service.hitachi.net> References: <1449455785-42020-1-git-send-email-wangnan0@huawei.com> In-Reply-To: <1449455785-42020-1-git-send-email-wangnan0@huawei.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.198.220.44] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB73YIlI001064 Content-Length: 1419 Lines: 41 >From: Wang Nan [mailto:wangnan0@huawei.com] > >There's a mistake in dso__adjust_kmod_long_name() that, it use strdup() >to dup the new long_name of a dso, but passes the original string >to dso__set_long_name(). Which causes random crash during cleanup. > Looks good to me:) Reviewed-by: Masami Hiramatsu Thanks! >Fixes: c03d5184f0e9("perf machine: Adjust dso->long_name for offline module") >Signed-off-by: Wang Nan >Cc: Arnaldo Carvalho de Melo >Cc: Masami Hiramatsu >Cc: Namhyung Kim >Cc: Zefan Li >Cc: pi3orama@163.com >--- > tools/perf/util/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c >index 95a7f60..bfc289c 100644 >--- a/tools/perf/util/machine.c >+++ b/tools/perf/util/machine.c >@@ -576,7 +576,7 @@ static void dso__adjust_kmod_long_name(struct dso *dso, const char *filename) > if (!dup_filename) > return; > >- dso__set_long_name(dso, filename, true); >+ dso__set_long_name(dso, dup_filename, true); > } > > struct map *machine__findnew_module_map(struct machine *machine, u64 start, >-- >1.8.3.4 ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?