Subject: Re: [PATCH v3 2/5] drm/dsi: Try to match non-DT dsi devices
References: <201511302050.evPZc1zs%fengguang.wu@intel.com>
Cc: a.hajda@samsung.com, linux-kernel@vger.kernel.org, airlied@linux.ie,
        treding@nvidia.com, l.stach@pengutronix.de, robh@kernel.org,
        linux-arm-msm@vger.kernel.org, jani.nikula@linux.intel.com
To: dri-devel@lists.freedesktop.org, daniel@ffwll.ch
From: Archit Taneja <architt@codeaurora.org>
Message-ID: <56651937.1080405@codeaurora.org>
Date: Mon, 7 Dec 2015 10:59:27 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <201511302050.evPZc1zs%fengguang.wu@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1942
Lines: 55

Hi,

On 11/30/2015 06:15 PM, kbuild test robot wrote:
> Hi Archit,
>
> [auto build test ERROR on: v4.4-rc3]
> [also build test ERROR on: next-20151127]
>
> url:    https://github.com/0day-ci/linux/commits/Archit-Taneja/drm-dsi-DSI-for-devices-with-different-control-bus/20151130-200725
> config: x86_64-allyesdebian (attached as .config)
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>     drivers/gpu/drm/drm_mipi_dsi.c: In function 'of_mipi_dsi_device_add':
>>> drivers/gpu/drm/drm_mipi_dsi.c:168:6: error: implicit declaration of function 'of_modalias_node' [-Werror=implicit-function-declaration]
>       if (of_modalias_node(node, info.type, sizeof(info.type)) < 0) {

Any suggestions on how to fix this? Is it ok to make DRM_MIPI_DSI
depend on CONFIG_OF? Or is it better to wrap these funcs around
IF_ENABLED(CONFIG_OF)?

Archit

>           ^
>     cc1: some warnings being treated as errors
>
> vim +/of_modalias_node +168 drivers/gpu/drm/drm_mipi_dsi.c
>
>     162	{
>     163		struct device *dev = host->dev;
>     164		struct mipi_dsi_device_info info = { };
>     165		int ret;
>     166		u32 reg;
>     167	
>   > 168		if (of_modalias_node(node, info.type, sizeof(info.type)) < 0) {
>     169			dev_err(dev, "modalias failure on %s\n", node->full_name);
>     170			return ERR_PTR(-EINVAL);
>     171		}
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/