Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755458AbbLGGPM (ORCPT ); Mon, 7 Dec 2015 01:15:12 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:55663 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbbLGGPK (ORCPT ); Mon, 7 Dec 2015 01:15:10 -0500 Date: Sun, 6 Dec 2015 23:15:03 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Martin Wilck , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Uwe Kleine-K?nig Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151207061503.GA19314@obsidianresearch.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> <20151203060042.GB10359@intel.com> <20151203181932.GA22973@obsidianresearch.com> <20151206040226.GA4396@intel.com> <20151206041544.GA5585@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151206041544.GA5585@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 30 On Sun, Dec 06, 2015 at 06:15:44AM +0200, Jarkko Sakkinen wrote: > You can completely ignore this question. I saw Martins reply with a fix for > "tpm_tis: Use devm_ioremap_resource" that you should squash into that > change. It isn't quite the right fix - but I've added something that should be OK now that Martin has debugged it. > So it's proved that TPM ACPI device objects do not always have a > memory resource. Good. Hopefully.. It is so confusing because tpm_tis had that wrong fallback, and tpm_crb incorrectly doesn't use the resource structure. So we've never actually had anything that requires the resource struct for 2.0 until now. > resubmit a new revision of the series to the mailing list so that it can > be peer-reviewed once again. If Martin is happy I will send them to the list, the latest patches are on my github: https://github.com/jgunthorpe/linux/commits/for-jarkko Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/