Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753342AbbLGG63 (ORCPT ); Mon, 7 Dec 2015 01:58:29 -0500 Received: from mail-ph.de-nserver.de ([85.158.179.214]:25032 "EHLO mail-ph.de-nserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752539AbbLGG61 (ORCPT ); Mon, 7 Dec 2015 01:58:27 -0500 X-Fcrdns: No Subject: Re: Asterisk deadlocks since Kernel 4.1 To: Herbert Xu References: <564DC4A5.70104@profihost.ag> <564DCC4C.1090009@redhat.com> <564E2852.8000200@profihost.ag> <56530A42.6030609@profihost.ag> <1448283451.4019628.447573353.3659E447@webmail.messagingengine.com> <565EBDC1.1090808@profihost.ag> <8737vlt6xb.fsf@stressinduktion.org> <5661DAC4.8040909@profihost.ag> <20151205010819.GA21889@gondor.apana.org.au> <5664A102.2030602@profihost.ag> <20151207012042.GA7420@gondor.apana.org.au> Cc: Hannes Frederic Sowa , Florian Weimer , Thomas Gleixner , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jannik Winkel , Marco Schinkel , "David S. Miller" , stable@vger.kernel.org From: Stefan Priebe - Profihost AG Message-ID: <56652E11.4010604@profihost.ag> Date: Mon, 7 Dec 2015 07:58:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151207012042.GA7420@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-User-Auth: Auth by hostmaster@profihost.com through 185.39.223.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 46 Hi Herbert, Am 07.12.2015 um 02:20 schrieb Herbert Xu: > On Sun, Dec 06, 2015 at 09:56:34PM +0100, Stefan Priebe wrote: >> Hi Herbert, >> >> i think i found the issue in 4.1 with netlink. Somebody made a >> mistake while backporting or cherry-picking your patch "netlink: Fix >> autobind race condition that leads to zero port ID" to 4.1. >> >> It misses a goto in 4.1. >> >> This goto is missing in 4.1: >> >> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c >> index 4017e12..f15c001 100644 >> --- a/net/netlink/af_netlink.c >> +++ b/net/netlink/af_netlink.c >> @@ -1132,7 +1132,6 @@ static int netlink_insert(struct sock *sk, u32 portid) >> if (err == -EEXIST) >> err = -EADDRINUSE; >> sock_put(sk); >> - goto err; >> } >> >> /* We need to ensure that the socket is hashed and visible. */ >> >> Can you please confirm, that this is not correct and might cause >> those issues. > > Well spotted! Yes this would be a fatal error and can cause the > problems you guys are seeing. Thanks, good. Can you help me to get this fix upstream into the stable lines? Stefan > > Thanks, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/