Subject: Re: [PATCH v10 01/17] drm: bridge: analogix/dp: split exynos dp
 driver to bridge directory
To: Inki Dae <inki.dae@samsung.com>, Mark Yao <mark.yao@rock-chips.com>,
        Jingoo Han <jingoohan1@gmail.com>, Heiko Stuebner <heiko@sntech.de>
References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com>
 <1449470312-30880-1-git-send-email-ykk@rock-chips.com>
Cc: Thierry Reding <treding@nvidia.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Andrzej Hajda <a.hajda@samsung.com>,
        Joonyoung Shim <jy0922.shim@samsung.com>,
        Seung-Woo Kim <sw0312.kim@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Russell King <linux@arm.linux.org.uk>, emil.l.velikov@gmail.com,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Kishon Vijay Abraham I <kishon@ti.com>, ajaynumb@gmail.com,
        javier@osg.samsung.com, Andy Yan <andy.yan@rock-chips.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
From: Yakir Yang <ykk@rock-chips.com>
Message-ID: <56653746.5040306@rock-chips.com>
Date: Mon, 7 Dec 2015 15:37:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1449470312-30880-1-git-send-email-ykk@rock-chips.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2454
Lines: 64


On 12/07/2015 02:38 PM, Yakir Yang wrote:
> Split the dp core driver from exynos directory to bridge directory,
> and rename the core driver to analogix_dp_*, rename the platform
> code to exynos_dp.
>
> Beside the new analogix_dp driver would export six hooks.
> "analogix_dp_bind()" and "analogix_dp_unbind()"
> "analogix_dp_suspned()" and "analogix_dp_resume()"
> "analogix_dp_detect()" and "analogix_dp_get_modes()"
>
> The bind/unbind symbols is used for analogix platform driver to connect
> with analogix_dp core driver. And the detect/get_modes is used for analogix
> platform driver to init the connector.
>
> They reason why connector need register in helper driver is rockchip drm
> haven't implement the atomic API, but Exynos drm have implement it, so
> there would need two different connector helper functions, that's why we
> leave the connector register in helper driver.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> similarity index 50%
> rename from drivers/gpu/drm/exynos/exynos_dp_core.c
> rename to drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index aee3262..cd86413 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>   
> -static int exynos_dp_remove(struct platform_device *pdev)
> +void analogix_dp_unbind(struct device *dev, struct device *master,
> +			void *data)
>   {
> -	pm_runtime_disable(&pdev->dev);
> -	component_del(&pdev->dev, &exynos_dp_ops);
> +	struct analogix_dp_device *dp = dev_get_drvdata(dev);
>   
> -	return 0;
> +	analogix_dp_bridge_disable(dp->bridge);
> +	pm_runtime_disable(&pdev->dev);
>   }
> +EXPORT_SYMBOL_GPL(analogix_dp_unbind);
>   

Sorry to introduce an compiled error, my test 4.4-rc3 kernel have some
different with linux-next kernel, so i used to write the patches on next 
kernel,
and back the changes to my 4.4 kernel to test.

I already found this error when I'm testing, but forget to reserver this 
changes
to linux-next kernel, I would send a new version to fix this.

- Yakir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/