Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbbLGH5k (ORCPT ); Mon, 7 Dec 2015 02:57:40 -0500 Received: from mail-am1on0084.outbound.protection.outlook.com ([157.56.112.84]:6444 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752383AbbLGH5h convert rfc822-to-8bit (ORCPT ); Mon, 7 Dec 2015 02:57:37 -0500 From: Haggai Eran To: Nicholas Krause , "dledford@redhat.com" CC: "sean.hefty@intel.com" , "hal.rosenstock@gmail.com" , "jgunthorpe@obsidianresearch.com" , Matan Barak , "yun.wang@profitbricks.com" , "ted.h.kim@oracle.com" , Doron Tsur , Erez Shitrit , "david.ahern@oracle.com" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path Thread-Topic: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path Thread-Index: AQHRLr4DdJR3VRnZqEayMoNH4NpFFp6/K8FM Date: Mon, 7 Dec 2015 07:57:33 +0000 Message-ID: References: <1449252173-12131-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1449252173-12131-1-git-send-email-xerofoify@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=haggaie@mellanox.com; x-originating-ip: [46.121.82.195] x-microsoft-exchange-diagnostics: 1;HE1PR05MB1465;5:QQ7gVTXe6N8Ftm+Ar9KwFfO1Pw0z4RHa+aZHSmhl+UaUt19wGbH6F3wWf2xCEMvqgh93hLn+t2C9OqFxhaHtuPuZZIp6E0BAyXavOIWZ+JlIOQiCCc38C4dtVLryRjAtnaSIodYPsFK8h9RxbqrZFw==;24:02mvxiY64bSeKof7UN1eXLETPUkc0YYYM5NdGMIRvti9KrkBM027K8RsVgfNE1fLYotcEoB2KjS8UyPAmdg2zM5W0kL29PEBd2OSrPC60E8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1465; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(34787635062028)(146099531331640)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:HE1PR05MB1465;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1465; x-forefront-prvs: 078310077C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(54094003)(189002)(24454002)(199003)(5003600100002)(86362001)(5002640100001)(189998001)(122556002)(19580395003)(87936001)(92566002)(106116001)(40100003)(19580405001)(101416001)(10400500002)(50986999)(105586002)(54356999)(81156007)(5001770100001)(5001960100002)(76176999)(33656002)(97736004)(66066001)(74316001)(106356001)(3846002)(5008740100001)(2501003)(586003)(5004730100002)(77096005)(2900100001)(76576001)(1220700001)(1096002)(2950100001)(102836003)(6116002)(11100500001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB1465;H:HE1PR05MB1355.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2015 07:57:33.4787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1465 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 24 On Friday, December 4, 2015 8:02 PM, Nicholas Krause wrote: > To: dledford@redhat.com > Cc: sean.hefty@intel.com; hal.rosenstock@gmail.com; Haggai Eran; jgunthorpe@obsidianresearch.com; Matan Barak; yun.wang@profitbricks.com; ted.h.kim@oracle.com; Doron Tsur; Erez Shitrit; david.ahern@oracle.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path > > This adds a needed error path in the function, cm_init_av_by_path > after the call to ib_init_ah_from_path in order to avoid incorrectly > accessing the path pointer of structure type ib_sa_path_rec if this > function call fails to complete its intended work successfully by > returning a error code. > > Signed-off-by: Nicholas Krause The subject doesn't seem to match the convention but apart from that, Reviewed-by: Haggai Eran I wonder if this should go to stable. If I understand correctly, this will fail only when the SGID isn't found in the GID table, but such connections would fail later on when creating a QP, right? Haggai-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/