Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754184AbbLGIXs (ORCPT ); Mon, 7 Dec 2015 03:23:48 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34925 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbbLGIXr (ORCPT ); Mon, 7 Dec 2015 03:23:47 -0500 Date: Mon, 7 Dec 2015 09:23:42 +0100 From: Ingo Molnar To: Rusty Russell Cc: Steven Rostedt , LKML , Peter Zijlstra , Andrew Morton , Sergey Senozhatsky , Xunlei Pang Subject: Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Message-ID: <20151207082342.GA13606@gmail.com> References: <20151203172428.600f380a@gandalf.local.home> <87lh9b573j.fsf@rustcorp.com.au> <20151203213745.52f21886@gandalf.local.home> <20151204073437.GA24827@gmail.com> <877fku553z.fsf@rustcorp.com.au> <20151206172936.GA29582@gmail.com> <87bna3rph4.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bna3rph4.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 30 * Rusty Russell wrote: > Ingo Molnar writes: > > * Rusty Russell wrote: > >> I don't think there are great answers here. But adding more subtle zeroing > >> semantics feels wrong, even if it will mostly Just Work. > > > > It's not subtle if the naming clearly reflects it (hence my suggestion to rename > > the API) - and the status quo for on-stack allocations is zeroing anyway, so it's > > not a big jump... > > True, but we already have zalloc_cpumask_var() though if we want that? Indeed, didn't realize that. > It probably makes sense to just switch everyone to that and get rid of the non-z > one? Yeah, I think this long-lived bug is a proper trigger for that. Lemme send a 2-patch series. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/