Date: Mon, 7 Dec 2015 11:31:09 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: devel@driverdev.osuosl.org, kirk@reisers.ca,
        Greg KH <gregkh@linuxfoundation.org>, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Christopher Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] Staging: speakup: kobjects: Return the error type to
 caller
Message-ID: <20151207083109.GC18797@mwanda>
References: <1449240153-3927-1-git-send-email-saurabh.truth@gmail.com>
 <20151207064847.GA18797@mwanda>
 <CAA8avJ-DPgF4JwLuVQ=810cq3ONMUnbktVHe5_EggfbsKJtxzw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA8avJ-DPgF4JwLuVQ=810cq3ONMUnbktVHe5_EggfbsKJtxzw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 30

On Mon, Dec 07, 2015 at 12:46:37PM +0530, Saurabh Sengar wrote:
> >> @@ -688,6 +689,8 @@ ssize_t spk_var_store(struct kobject *kobj, struct kobj_attribute *attr,
> >>
> >>       if (ret == -ERESTART)
> >>               pr_info("%s reset to default value\n", param->name);
> >
> > Is this really true?
> Sorry, I am not sure here what you mean here.
> I have not implemented it.
> >
> > This function is so weird and broken.  Please look at it some more and
> > fix it harder with a mallet.
> You mean I broke it ?

No, I mean it was broken to begin with.  Write a more extensive patch to
fix it.

That printk should be moved up to where we actually do the reset.
Anyway speakup is actually really bad and there is a lot of broken
stuff so you don't have to fix this function if you don't want to.  Just
fix the -ERANGE issue I mentioned and resend if you want.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/